Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skipping students version if on remote #3668

Merged
merged 2 commits into from
Jan 16, 2025
Merged

ci: skipping students version if on remote #3668

merged 2 commits into from
Jan 16, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 15, 2025

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner January 15, 2025 11:50
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (20f82d1) to head (584efb7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3668      +/-   ##
==========================================
- Coverage   87.11%   87.09%   -0.03%     
==========================================
  Files         187      187              
  Lines       14694    14694              
==========================================
- Hits        12801    12798       -3     
- Misses       1893     1896       +3

@germa89
Copy link
Collaborator Author

germa89 commented Jan 15, 2025

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 9e5592a into main Jan 16, 2025
61 of 62 checks passed
@germa89 germa89 deleted the ci/skipping-mapdl-student-versions-if-on-remote branch January 16, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees
No one assigned
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot